Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Data frame analytics: Advanced editor. (#43989) #44223

Merged
merged 4 commits into from
Aug 29, 2019

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

Adds an option to switch to an advanced (JSON) editor when creating an analytics job.

This builds upon the previous work for the modal for analytics job creation and the use of useReducer():

- The files of the custom hook useCreateAnalyticsForm() have been further split up and there's now separate actions.ts and state.ts files.
- To only allow updating what's really related to the form value's state via setFormState, the state structure has been updated and more fine grained actions have been added.
- The user can enabled the advanced editor, but cannot move back to the original form (there's a help text in the UI about that).
- The advanced editor component's (CreateAnalyticsAdvancedEditor) structure is based on the regular form, it still has an input field for the job ID and the toggle for optionally creating an index pattern. The fields for source/destination index are replaced by an editable JSON textarea input.
- The advanced editor features mostly the same validation like the regular form. For example, if the source index isn't valid, an error will be shown in a CallOut below the editable area.
@walterra walterra self-assigned this Aug 28, 2019
@walterra walterra added the :ml label Aug 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@walterra
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 45d12e0 into elastic:7.x Aug 29, 2019
@walterra walterra deleted the backport/7.x/pr-43989 branch August 29, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants